-
Notifications
You must be signed in to change notification settings - Fork 0
Separate plotting code from data prep #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
|
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
|
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
1 similar comment
|
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
| ) | ||
|
|
||
| #' @name constants | ||
| burden_outcome_names <- c( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also have deaths_cwyx, cases_cwyx, dalys_cwyx, yll_cwyx, rubella_deaths_congenital and rubella_cases_congenital.
|
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
|
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
xiangli313
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking good. I am approving it; and will be using it once merged (will feedback).
| #' @param year_min Minimum year. | ||
| #' | ||
| #' @export | ||
| prep_plot_fvp <- function(fvp, year_min, year_max) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiangli313 - I had a question regarding this function that prepares the FVP data for plotting. This function is used to generate the data for the FVPs-over-time plot (usually Fig. 2 in burden diagnostics reports). Where can I find an example of the FVPs dataset that is used to make the FVPs plot? The related plotting function is plot_fvp().
kgaythorpe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic, thanks Pratik, happy to approve from my side
| #' @param coverage WIP. Coverage data. | ||
| #' | ||
| #' @export | ||
| prep_plot_coverage_set <- function(coverage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiangli313 - similar question/request for some example coverage set data so that this function can be tested. This function prepares data that is used to generate the coverage set data (usually Fig. 1 in diagnostics reports). The related plotting function is plot_coverage_set().
|
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
This PR separates the data preparation for plotting into intermediate functions prefixed
prep_plot_*().Known issues:
- Two functions in; now removed.burden_diagnostics.Rare yet to be worked on