[Android] Handle gestures on transparent views directly under the Detector#3962
Open
j-piasecki wants to merge 1 commit intomainfrom
Open
[Android] Handle gestures on transparent views directly under the Detector#3962j-piasecki wants to merge 1 commit intomainfrom
j-piasecki wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Android hit-testing in GestureHandlerOrchestrator so that transparent views that are direct children of RNGestureHandlerDetectorView are still considered valid touch targets, aligning behavior with the new GestureDetector API expectations.
Changes:
- Add an explicit
RNGestureHandlerDetectorViewparent check when deciding whether a handlerless view can become a touch target. - Refactor the touch-target predicate into clearer intermediate booleans (
isLeaf,isNotTransparent,isDirectDetectorChild,isPointInView).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...andler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt
Show resolved
Hide resolved
...andler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the new API, the direct descendant of the Detector component always passes through
shouldHandlerlessViewBecomeTouchTarget. If that view happens to be transparent, it will not be taken into account during hit testing unless it's not a ViewGroup.This PR adds an explicit check to ensure that views that are direct children of a Detector component are always considered for hit testing, even if they are transparent.
Test plan