[Native] Automatically unflatten detector children#3963
Open
j-piasecki wants to merge 1 commit intomainfrom
Open
[Native] Automatically unflatten detector children#3963j-piasecki wants to merge 1 commit intomainfrom
j-piasecki wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the React Native Gesture Handler's Detector shadow node to automatically unflatten its child component, eliminating the need for developers to manually set collapsable={false}. This works in conjunction with PR #3962, which ensures transparent views under the Detector are properly handled during hit testing.
Changes:
- Override
appendChildandreplaceChildmethods to automatically unflatten child nodes - Implement
unflattenNodehelper that setsFormsViewandFormsStackingContexttraits on children - Update initialization logic to use the new replaceChild override
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| RNGestureHandlerDetectorShadowNode.h | Added method declarations for appendChild, replaceChild overrides and private unflattenNode helper |
| RNGestureHandlerDetectorShadowNode.cpp | Implemented child unflattening logic by setting shadow node traits when children are added or replaced |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Android this requires #3962 to test, as the non-transparent views are never flattened.
Automatically unflattens the child node of the detector component, so that setting
collapsable={false}is no longer needed.Test plan
Notce the lack of
collapsable={false}on the detector's child.