chore: update map baselines due to basemap change, upgrade Chrome versions in CI, and add temporary pin for flaky Chrome version #7690
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilykl
force-pushed
the
update-map-baselines-jan-2026
branch
3 times, most recently
from
a1746d6 to
52a3faf
Compare
…issues with 144) and bump pinned versions to 143 elsewhere
emilykl
force-pushed
the
update-map-baselines-jan-2026
branch
from
52a3faf to
b7d4a50
Compare
emilykl
changed the title
Contributor
|
@emilykl I keep seeing the no-gl-jasmine test suite failing. Do you know why that would be? |
Contributor
Author
|
@camdecoster I bumped the Chrome version everywhere, so presumably that's why. Going to try a diff Chrome version. It's a little odd though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The baseline images for some of the MapLibre image tests have changed due to the map tiles for the
'carto'map styles (hosted onbasemaps.cartocdn.com) being visually modified by Carto. This has caused the CI image tests to fail. This PR updates the baseline images so that the CI is green again.Separately: Chrome version 144 seems to be causing a large number of the WebGL Jasmine tests to fail (see failures here). This shows up in the
webgl-jasmine-chromeLatestjob. This PR pins the version of Chrome used bywebgl-jasmine-chromeLatestto 143. This pin should be temporary and removed as soon as Chrome patches fix the issues; I've opened [maintenance] Remove Chrome version 143 pin inwebgl-jasmine-chromeLatest#7693 to track.While we're at it, I've bumped the pinned Chrome versions elsewhere in the CI from 132 to 143.