Skip to content

Conversation

@jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 26, 2026

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

jfy133 and others added 30 commits February 28, 2025 21:55
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
@jfy133
Copy link
Member Author

jfy133 commented Jan 26, 2026

They are all container pulling timeout errors, but works fine locally so I will merge!

@jfy133
Copy link
Member Author

jfy133 commented Jan 26, 2026

Thank you @prototaxites @maxulysse @SPPearce !

@jfy133 jfy133 merged commit cfac055 into nf-core:master Jan 26, 2026
41 of 46 checks passed
@jfy133 jfy133 deleted the metabat-fix branch January 26, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants