Merged
Conversation
Member
|
Do you know if there is a tool that could automatically enforce these style rules? I think your suggested changes are very good, I just want to ensure that they will stay that way and that other places can be safely refactored as well. |
Signed-off-by: WrenIX <dev@wrenix.eu>
wrenix
force-pushed
the
chore/metrics-indent
branch
from
e09d9af to
76825b4
Compare
Collaborator
Author
|
At the moment, i do not know any tools - i will take a look into the chart-testing you already use (it use in background the yamllint tool written in python) |
provokateurin
approved these changes
Feb 2, 2024
Member
|
Shall we merge this already or wait for a potential tool that could enforce the style? |
Collaborator
Author
|
i like to create the next PR ... in the end, i want also add some chart-testing values-files as best practics ... maybe we discuss it there. e.g.: a6ca7bd |
3 tasks
This was referenced Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
array with:
instatt of
this is just of templating part
{{-will remove all spaces before that, so moved to level of yaml structure.(i change of
{{to{{-will happen in another PR with the replace ofiftowhen).draft, i am waiting for the merge of #516