chore: replace if with with (and improve strip using with -)#518
Merged
provokateurin merged 1 commit intonextcloud:mainfrom Feb 4, 2024
Merged
chore: replace if with with (and improve strip using with -)#518provokateurin merged 1 commit intonextcloud:mainfrom
provokateurin merged 1 commit intonextcloud:mainfrom
Conversation
wrenix
force-pushed
the
chore/metrics
branch
3 times, most recently
from
52f5312 to
5b95eb7
Compare
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, but I think in a few places nindent is used where indent would be enough. Could you fix that?
Collaborator
Author
|
I am a hours away from keyboard, sry -> i believe there is needed, but i take a look |
Collaborator
Author
|
you are correct, if i would not use in some places that is a kind of personal preference. should i change it? |
Member
|
I see, that makes sense. Then I prefer this style :) Still, it would be great to have a tool to enforce the style. |
Signed-off-by: WrenIX <dev.github@wrenix.eu>
Collaborator
Author
|
increase chart-version after rebase |
provokateurin
approved these changes
Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
Chart.yamlaccording to semver.