chore: move metrics yaml to extra folder#516
Conversation
|
I understand you are frustrated, but please stay friendly towards others https://nextcloud.com/contribute/code-of-conduct/ |
|
Honestly I'm not sure if this change makes sense. According to https://helm.sh/docs/chart_best_practices/templates/ the current structure is best practice and the page doesn't mention that subdirectories are allowed (but it also doesn't say they are not allowed). https://stackoverflow.com/a/77619725 suggests that it still works, even if it is not documented. |
|
your first link is good, but it does not say anything about, if much of your stackoverflow post, say - that it works (and yes it works also for application charts). |
provokateurin
left a comment
There was a problem hiding this comment.
Either way, I see that is change makes sense to make the structure less cluttered.
|
that change does not change any logic -> semver a chore, which does not need a new version, but maybe your ci failed ... |
|
CI is still running, I'm not sure if it will require a new version 🤔 |
Signed-off-by: WrenIX <dev@wrenix.eu>
|
it needs: https://github.com/nextcloud/helm/actions/runs/7754331260/job/21148125372?pr=516 |
a first / last try of a really easy reviewable PR
if you see this and need more then 5min ....
@provokateurin
a split of #481 which is an split of #478 (which does not contain any changes in logic and is 2,5 month old)