-
Notifications
You must be signed in to change notification settings - Fork 19
[OFF-831]: Add download web bile nanoflow action #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikolai-paramonov
wants to merge
3
commits into
main
Choose a base branch
from
off/831-add-download-file-action-for-web
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
packages/jsActions/nanoflow-actions-native/src/client/DownloadWebFile.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // This file was generated by Mendix Studio Pro. | ||
| // | ||
| // WARNING: Only the following code will be retained when actions are regenerated: | ||
| // - the import list | ||
| // - the code between BEGIN USER CODE and END USER CODE | ||
| // - the code between BEGIN EXTRA CODE and END EXTRA CODE | ||
| // Other code you write will be lost the next time you deploy the project. | ||
|
|
||
| // BEGIN EXTRA CODE | ||
| // END EXTRA CODE | ||
|
|
||
| /** | ||
| * @param {MxObject} file - File object which will be downloaded. | ||
| * @param {boolean} showFileInBrowser - Set to True to let the browser open the file in a new tab. | ||
| * Set to False if the file only needs to be downloaded to the device storage. | ||
| * @returns {Promise.<void>} | ||
| */ | ||
| export async function DownloadWebFile(file?: mendix.lib.MxObject, showFileInBrowser?: boolean): Promise<void> { | ||
| // BEGIN USER CODE | ||
| if (!file) { | ||
| return Promise.reject(new Error("Input parameter 'file' is required")); | ||
| } | ||
|
|
||
| const target = showFileInBrowser ? "window" : "internal"; | ||
|
|
||
| return new Promise((resolve, reject) => { | ||
| mx.ui | ||
| .downloadFile({ | ||
| mxobject: file, | ||
| target, | ||
| error: (err: Error) => reject(err) | ||
| }) | ||
| .then(resolve) | ||
| .catch(reject); | ||
| }); | ||
| // END USER CODE | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is done in the NMR project, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the projects and releases are so connected, therefore, I decided to list them in here as well. Do you think I should remove this line from here?