Skip to content

Conversation

@nikolai-paramonov
Copy link

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ❌
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅

Feature specific

  • Comply with designs ✅
  • Comply with PM's requirements ✅

Please remove unnecessary emojis and sections and this comment before proceeding

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

  • Added a "Download web file" nanoflow action that triggers file download for web applications.
  • Changed a caption for the existing "Download file" action to "Download native file".

Relevant changes

  • Changed a caption for the existing "Download file" action to "Download native file" to prevent similar names with the new action.

What should be covered while testing?

The new "Download web file" nanoflow action.

@nikolai-paramonov nikolai-paramonov requested a review from a team as a code owner January 22, 2026 15:13
* Set to False if the file only needs to be downloaded to the device storage.
* @returns {Promise.<void>}
*/
export async function DownloadWebFile(file?: mendix.lib.MxObject, showFileInBrowser?: boolean) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add the missing return type?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

## [Unreleased]

- Added a "Download web file" nanoflow action that triggers file download for web applications.
- Changed a caption for the existing "Download file" action to "Download native file".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is done in the NMR project, correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the projects and releases are so connected, therefore, I decided to list them in here as well. Do you think I should remove this line from here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants