-
Notifications
You must be signed in to change notification settings - Fork 19
[OFF-831]: Add download web bile nanoflow action #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| * Set to False if the file only needs to be downloaded to the device storage. | ||
| * @returns {Promise.<void>} | ||
| */ | ||
| export async function DownloadWebFile(file?: mendix.lib.MxObject, showFileInBrowser?: boolean) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add the missing return type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks.
| ## [Unreleased] | ||
|
|
||
| - Added a "Download web file" nanoflow action that triggers file download for web applications. | ||
| - Changed a caption for the existing "Download file" action to "Download native file". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is done in the NMR project, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the projects and releases are so connected, therefore, I decided to list them in here as well. Do you think I should remove this line from here?
Checklist
[XX-000]: description)? ✅Feature specific
Please remove unnecessary emojis and sections and this comment before proceeding
This PR contains
What is the purpose of this PR?
Relevant changes
What should be covered while testing?
The new "Download web file" nanoflow action.