[Feat] migrate code from ros1 to ros2#131
Conversation
8bc59f9 to
fe99cc2
Compare
|
@sujit-168 I have added a couple of new commits to your work, so that the parameters are set on the main node properly: Also, your version of Vikit isn't public, so the version I have compiled against is here: https://github.com/integralrobotics/rpg_vikit.git I was thinking about modernising the |
|
@james-ward Thank you for contributing to this pull request, especially for open-sourcing your completely modified solution. Your modifications to Vikit are another interesting approach. |
|
I have put in a PR to your original branch: Robotic-Developer-Road#1 |
|
@james-ward Regarding the way to read camera parameters, my suggestion is to keep two solutions so that the community can refer to them. This issue can have more discussions. |
Sure. But until you release the version of Vikit you are using I couldn't get your method to work. |
45a4942 to
137b660
Compare
Thank for the work, I have some trouble with sophus -- fast-livo2 demand sophus on a specific commit, but vikit seems cannot build with that, se3 is .h for fast-livo2 and .hpp for vikit. Can you share which sophus version you are using? |
|
@biggiantpigeon you can find it in README.md |
My version just uses the current version in the Ubuntu APT repo. |
I use method mentioned in #128 (comment) and it works, maybe consider update sophus part in readme~ |
OK, this way will be updated in |
The rpg_vikit module I used is now open-source, and FAST-LIVO2 will soon be updated with the latest upstream modifications from the HKU-MARS lab. |
…ifferent ROS2 distributions
…ethods in LIVMapper
The key migration part occurs in the following commits, other commits are about minor changes.