Skip to content

Set parameters directly in lidar mapping node#1

Open
james-ward wants to merge 23 commits intoRobotic-Developer-Road:humblefrom
integralrobotics:ros2
Open

Set parameters directly in lidar mapping node#1
james-ward wants to merge 23 commits intoRobotic-Developer-Road:humblefrom
integralrobotics:ros2

Conversation

@james-ward
Copy link

No description provided.

james-ward and others added 3 commits April 1, 2025 10:45
Signed-off-by: Tanner, Gilbert <gilbertta@edu.aau.at>
Signed-off-by: Tanner, Gilbert <gilbertta@edu.aau.at>
james-ward and others added 2 commits April 9, 2025 00:44
fix: Change Velodyne message time handling
fix: Complilation errors on ROS versions older than Iron
@vic-bart
Copy link

Hi! @sujit-168 is there a reason this hasn't been merged yet? @james-ward were you still working on this?

@sujit-168
Copy link

sujit-168 commented Jan 26, 2026

@vic-bart

Hi! @sujit-168 is there a reason this hasn't been merged yet? @james-ward were you still working on this?您好!请问为什么这个修改还没有合并?您还在处理这个问题吗?

You can find the answer at the following link.

hku-mars#131 (comment)

@vic-bart
Copy link

You can find the answer at the following link.

Thanks for replying. I checked out the PR's comments, and (correct me if I'm wrong) it seems that this PR used integralrobotics' rpg_vikit fork, instead of Robotic-Developer-Road's rgp_vikit fork which only open-sourced last Dec (here).

Does this mean someone just has to make sure this PR uses Robotic-Developer-Road's version of rpg_vikit?

@sujit-168
Copy link

sujit-168 commented Feb 2, 2026

You can find the answer at the following link.您可以通过以下链接找到答案。

Thanks for replying. I checked out the PR's comments, and (correct me if I'm wrong) it seems that this PR used integralrobotics' rpg_vikit fork, instead of Robotic-Developer-Road's rgp_vikit fork which only open-sourced last Dec (here).感谢回复。我查看了 PR 的评论,(如果我错了请纠正我)这个 PR 似乎使用的是 integralrobotics 的 rpg_vikit 分支 ,而不是 Robotic-Developer-Road 的 rgp_vikit 分支 (该分支直到去年 12 月才开源)。

@vic-bart
That's a good question, but I haven't tested the integralrobotics' rpg_vikit branch yet. If you're interested in testing it, please feel free to share your test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants