Don't break on updated Rjs out functionality#235
Open
AStoker wants to merge 1 commit intoguybedford:masterfrom
Open
Don't break on updated Rjs out functionality#235AStoker wants to merge 1 commit intoguybedford:masterfrom
out functionality#235AStoker wants to merge 1 commit intoguybedford:masterfrom
Conversation
Resolves: guybedford#231, guybedford#229 With new Rjs, `out` can be a function (https://github.com/requirejs/r.js/blob/master/build/example.build.js#L448). Need to support dealing with `out` as being a function. In this case, simply checking if the property is a string, and if not, `toString`-ing it will allow the `siteRoot` to be determined correctly.
Collaborator
|
@AStoker I saw issues u mentioned, and I will review this PR detailed this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #231, #229
With new Rjs,
outcan be a function (https://github.com/requirejs/r.js/blob/master/build/example.build.js#L448). Need to support dealing withoutas being a function. In this case, simply checking if the property is a string, and if not,toString-ing it will allow thesiteRootto be determined correctly.