fix css-builder in node 6 or higher when config.dir is undefined#232
Open
oyola0 wants to merge 1 commit intoguybedford:masterfrom
oyola0:master
Open
fix css-builder in node 6 or higher when config.dir is undefined#232oyola0 wants to merge 1 commit intoguybedford:masterfrom oyola0:master
oyola0 wants to merge 1 commit intoguybedford:masterfrom
oyola0:master
Conversation
|
+1 |
Collaborator
|
Looks similar to #235. Will review more detailed this weekend. |
huseyinalp-zz
approved these changes
Jul 12, 2018
huseyinalp-zz
left a comment
huseyinalp-zz
left a comment
There was a problem hiding this comment.
This change works as expected with gulp-requirejs.
I think you can merge.
Owner
|
I am no longer maintaining this project, but if anyone is interested in doing that I will gladly provide access. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In node 6 or higher if path.dirname not receipt a string, throw a exception.
https://nodejs.org/dist/latest-v6.x/docs/api/path.html#path_path_dirname_path