Skip to content

fix: correct visibility option #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twangodev merged 2 commits into from
Jan 22, 2026
Merged

fix: correct visibility option #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ece733f
fix: correct visibility option from "unlisted" to "unlist" in shared.…
twangodev Jan 22, 2026
9840966
fix: update test for voice visibility from "unlisted" to "unlist"
twangodev Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fishaudio/types/shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class PaginatedResponse(BaseModel, Generic[T]):
AudioFormat = Literal["wav", "pcm", "mp3", "opus"]

# Visibility types
Visibility = Literal["public", "unlisted", "private"]
Visibility = Literal["public", "unlist", "private"]

# Training mode types
TrainMode = Literal["fast"]
Expand Down
2 changes: 1 addition & 1 deletion src/fishaudio/types/voices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class Voice(BaseModel):
created_at: Timestamp when the model was created
updated_at: Timestamp when the model was last updated
languages: List of supported language codes (e.g., ["en", "zh"])
visibility: Model visibility. Options: "public", "private", "unlisted"
visibility: Model visibility. Options: "public", "private", "unlist"
lock_visibility: Whether visibility setting is locked
like_count: Number of likes the model has received
mark_count: Number of bookmarks/favorites
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ def test_tts_request_custom_new_parameters(self):
class TestVoiceVisibility:
"""Test Voice model with updated visibility."""

def test_voice_with_unlisted_visibility(self, sample_voice_response):
"""Test Voice model with 'unlisted' visibility."""
sample_voice_response["visibility"] = "unlisted"
def test_voice_with_unlist_visibility(self, sample_voice_response):
"""Test Voice model with 'unlist' visibility."""
sample_voice_response["visibility"] = "unlist"
voice = Voice.model_validate(sample_voice_response)
assert voice.visibility == "unlisted"
assert voice.visibility == "unlist"