-
Notifications
You must be signed in to change notification settings - Fork 25
fix: correct visibility option #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThe pull request renames the visibility literal from "unlisted" to "unlist" in the shared types, updates the Voice model docstring to match, and adjusts unit tests to expect "unlist" instead of "unlisted". Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request corrects the visibility option value from "unlisted" to "unlist" in the type definitions, aligning the newer fishaudio SDK with the legacy fish_audio_sdk which already uses "unlist".
Changes:
- Updated
Visibilitytype literal inshared.pyfrom "unlisted" to "unlist" - Updated documentation comment in
voices.pyto reflect the corrected value
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/fishaudio/types/shared.py | Updated the Visibility type definition to use "unlist" instead of "unlisted" |
| src/fishaudio/types/voices.py | Updated the docstring comment to document "unlist" instead of "unlisted" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/fishaudio/types/shared.py`:
- Line 30: The Visibility Literal was changed to accept "unlist" not "unlisted",
which breaks test_voice_with_unlisted_visibility; add a Pydantic validator on
the Voice model (e.g., a `@validator` or root_validator in the Voice class) that
accepts the legacy string "unlisted" and normalizes it to "unlist" before
validation (ensuring Visibility still uses
Literal["public","unlist","private"]), update tests/unit/test_types.py to either
send "unlist" or rely on the new normalization in
test_voice_with_unlisted_visibility, and finally bump the package version and
add a short changelog entry noting the Visibility value change and the
backward-compatible normalization.
67b6f06 to
9840966
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Bug Fixes
Tests
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.