Skip to content

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 28, 2026

Overview

prepare execution/evm and bump ev-node

@github-actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJan 28, 2026, 9:57 AM

@claude
Copy link
Contributor

claude bot commented Jan 28, 2026

Claude finished @julienrbrt's task in 1m 42s —— View job


Code Review Complete

I've completed a comprehensive review of this PR which prepares execution-related modules for the v1.0.0-rc.1 release by standardizing version references across the multi-module repository.

Tasks

  • Read and analyze all changed go.mod files
  • Review dependency version updates for consistency
  • Check go.sum files for correctness
  • Verify alignment with "prepare execution release" purpose
  • Provide comprehensive review feedback

Review Summary

Overall Assessment:APPROVED - This is a clean, necessary dependency update to align execution modules with the rc.1 release.

Detailed Review

1. Code Quality & Architecture ✅

Positive Observations:

  • Consistent dependency upgrades: All modules consistently upgrade github.com/evstack/ev-node from various beta versions (beta.6, beta.10, beta.11) to v1.0.0-rc.1
  • Clean replace directive consolidation: The PR removes redundant replace directives for the main module (github.com/evstack/ev-node => ../../) in several modules, which is correct since these modules are now referencing the published rc.1 version
  • Proper modular architecture: The changes respect the multi-module architecture with targeted updates only to modules that depend on the main ev-node package

Files Updated:

  • apps/evm/go.mod: beta.10 → rc.1, removed redundant replace
  • apps/grpc/go.mod: beta.11 → rc.1, removed redundant replace
  • apps/testapp/go.mod: beta.10 → rc.1, removed replace directive
  • execution/evm/go.mod: beta.10 → rc.1, removed replace directive
  • execution/grpc/go.mod: beta.11 → rc.1, removed replace directive
  • tools/da-debug/go.mod: beta.6 → rc.1, removed replace directive
  • execution/evm/test/go.mod: beta.10 → rc.1 (indirect dependency)
  • test/e2e/go.mod: beta.10 → rc.1

2. Error Handling & Resilience ✅

No changes to error handling code - This is purely a dependency version update, so no error handling review is needed.

3. Security ✅

Security Assessment:

  • ✅ No security-sensitive code changes
  • ✅ Version bump from beta to rc.1 follows semantic versioning
  • ✅ All go.sum files updated correctly with proper checksums for the new rc.1 dependency
  • ✅ No introduction of new dependencies or external packages

4. Performance & Resource Efficiency ✅

No performance impact - Dependency version updates only, no code changes affecting performance.

5. Testing & Reliability

Observations:

  • ⚠️ Missing PR Description: The PR has an empty "Overview" section, which makes it harder for reviewers to understand the motivation and scope
  • ✅ Buf checks passed (protobuf breaking change detection, linting, formatting)
  • ℹ️ Recommendation: The PR should be tested with the full test suite (make test-all) to ensure all modules work correctly with rc.1

Test Coverage Note:
While this is a version bump, it's important to verify:

  • All unit tests pass with the new dependency versions
  • Integration tests confirm module compatibility
  • E2E tests validate the entire system with rc.1 dependencies

6. Documentation & Developer Experience

Issues Identified:

  1. Empty PR Description ⚠️

    • Location: PR body
    • Issue: The "Overview" section is completely empty
    • Impact: Makes it difficult for reviewers and future maintainers to understand the context
    • Recommendation: Add a brief description explaining:
      • This prepares execution modules for the v1.0.0-rc.1 release
      • Updates all execution-related modules to reference rc.1
      • Removes now-unnecessary replace directives for published version
      • Part of the release preparation process
  2. Inconsistent Replace Directive Handling ℹ️

    • Observation: Some modules keep their replace directives (e.g., apps/evm keeps replace github.com/evstack/ev-node/execution/evm => ../../execution/evm), while others remove them
    • Analysis: This is actually correct - local replace directives for unpublished sub-modules should be kept, while replace directives for the main published module should be removed
    • No action needed - current state is appropriate

Consistency Analysis

Version Alignment Check:

  • github.com/evstack/ev-node: All updated to v1.0.0-rc.1
  • github.com/evstack/ev-node/core: Already at v1.0.0-rc.1 across all modules
  • github.com/evstack/ev-node/execution/evm: Remains at v1.0.0-beta.3 (execution modules have different versioning)
  • ✅ All go.sum files have corresponding checksums added

Replace Directives - Correctly Updated:

  • ✅ Removed from: apps/evm, apps/grpc, apps/testapp, execution/evm, execution/grpc, tools/da-debug
  • ✅ Kept local-only replace directives for unpublished sub-modules

Alignment with Release Goals

This PR correctly prepares the codebase for the execution release by:

  1. ✅ Upgrading all execution-related modules to reference the rc.1 release candidate
  2. ✅ Cleaning up local development replace directives that are no longer needed
  3. ✅ Maintaining consistency across the multi-module structure
  4. ✅ Ensuring go.sum integrity with proper checksums

Recommendations

  1. Add PR Description: Please add context to the PR overview explaining this is a dependency version alignment for rc.1
  2. Verify Test Suite: Run make test-all to confirm all tests pass with the updated dependencies
  3. Consider Changelog Update: Ensure CHANGELOG.md reflects this release preparation (appears to already be done in commit 122486d)

Minor Observations

  • The PR correctly preserves the Google genproto pinning at the bottom of go.mod files to avoid ambiguous imports
  • No unintended dependency additions or removals detected
  • The core module (github.com/evstack/ev-node/core) is already at rc.1, showing good version coordination

Verdict: This is a well-executed dependency update PR that properly prepares execution modules for the rc.1 release. The only improvement would be adding a PR description for better documentation.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a preparatory step for an upcoming execution release. It updates the core github.com/evstack/ev-node dependency across various applications and execution modules to its v1.0.0-rc.1 release candidate version. Additionally, it removes local replace directives for this main module, signifying a move towards standard module consumption rather than local path replacements.

Highlights

  • Dependency Version Update: The primary github.com/evstack/ev-node dependency has been updated across all affected modules from various beta versions (e.g., v1.0.0-beta.10, v1.0.0-beta.11, v1.0.0-beta.6) to v1.0.0-rc.1.
  • Local Replace Directives Removed: Several go.mod files no longer use local replace directives for the main github.com/evstack/ev-node module, indicating a transition to consuming it as a published module rather than a local path.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.61%. Comparing base (122486d) to head (ad5671b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3021   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files         116      116           
  Lines       11477    11477           
=======================================
  Hits         6383     6383           
  Misses       4394     4394           
  Partials      700      700           
Flag Coverage Δ
combined 55.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt enabled auto-merge January 28, 2026 10:02
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares for a new release by updating dependencies across multiple go.mod files. The main change is bumping the github.com/evstack/ev-node dependency to version v1.0.0-rc.1. Additionally, several replace directives pointing to the local monorepo have been removed, which is a good practice to ensure that modules like example apps use the published versions of dependencies. I've found one minor improvement opportunity for consistency in your Go modules. Otherwise, the changes appear correct and consistent with the goal of a release preparation.

@julienrbrt julienrbrt added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 4a19108 Jan 28, 2026
33 checks passed
@julienrbrt julienrbrt deleted the julien/exec branch January 28, 2026 10:45
@claude claude bot mentioned this pull request Jan 28, 2026
alpe added a commit that referenced this pull request Jan 28, 2026
* main:
  ci: strip app prefix (#3028)
  ci: fix release workflow (#3027)
  chore: prep apps (#3025)
  build: fix docker-compose for evm (#3022)
  chore: prepare execution release (#3021)
  chore: prep changelog (#3020)
  refactor(e2e): extract shared test helpers to DockerTestSuite (#3017)
  feat: High availabilty via RAFT (#2987)
  chore: bump to core rc.1 (#3018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants