Skip to content

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 28, 2026

Overview

prep apps for tagging (testapp, grpc and evm will be tagged after this PR)

@julienrbrt julienrbrt requested a review from chatton January 28, 2026 11:03
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the dependency management for the evm and grpc applications. It transitions these applications from using local replace directives to relying on published release candidate versions of internal execution modules. This change aims to standardize module resolution, improve build consistency, and prepare the applications for more stable releases by aligning them with specific release candidate versions.

Highlights

  • Dependency Updates: The apps/evm and apps/grpc modules have had their go.mod files updated to reflect new dependency versions.
  • Removal of Local Replacements: The replace directives pointing to local paths for github.com/evstack/ev-node/execution/evm and github.com/evstack/ev-node/execution/grpc have been removed from their respective go.mod files.
  • Module Version Bumps: The github.com/evstack/ev-node/execution/evm dependency in apps/evm was updated from v1.0.0-beta.3 to v1.0.0-rc.1. Similarly, github.com/evstack/ev-node/execution/grpc in apps/grpc was updated from v0.0.0 to v1.0.0-rc.1.
  • Checksum Updates: The go.sum files for both apps/evm and apps/grpc were updated to include the correct checksums for the newly referenced v1.0.0-rc.1 versions of the execution/evm and execution/grpc modules.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@claude
Copy link
Contributor

claude bot commented Jan 28, 2026

Claude finished @julienrbrt's task in 1m 58s —— View job


Code Review Complete ✅

I've reviewed the dependency management updates in this PR. This change aligns with the project's release preparation workflow and follows proper Go module versioning practices.


Summary

This PR transitions apps/evm and apps/grpc from local development mode (using replace directives) to consuming published release candidate versions of their execution layer dependencies. This is a standard step before tagging new app releases.

Changes Analysis

apps/evm/go.mod:

  • ✅ Removed replace github.com/evstack/ev-node/execution/evm => ../../execution/evm
  • ✅ Upgraded execution/evm from v1.0.0-beta.3v1.0.0-rc.1
  • ✅ go.sum updated with correct checksums for v1.0.0-rc.1

apps/grpc/go.mod:

  • ✅ Removed replace github.com/evstack/ev-node/execution/grpc => ../../execution/grpc
  • ✅ Upgraded execution/grpc from v0.0.0v1.0.0-rc.1
  • ✅ go.sum updated with correct checksums for v1.0.0-rc.1

Review Findings

Correct Approach

  1. Consistent with previous workflow: Commit 4a19108 (chore: prepare execution release #3021) prepared the execution modules by removing their replace directives and bumping to rc.1. This PR correctly follows that pattern for the apps.
  2. Version alignment: Both apps now depend on the same v1.0.0-rc.1 versions of core and execution modules, ensuring consistency.
  3. Clean dependency resolution: Removing replace directives allows Go modules to resolve dependencies from published tags rather than local paths.

📋 Observations

  1. Module independence: This change makes apps/evm and apps/grpc independent modules that can be tagged separately, which aligns with the PR description's intent to tag these apps after merging.

  2. go.sum integrity: The checksum additions indicate the modules were successfully fetched from the remote repository (both h1: checksums present for go.mod and source).

  3. Minimal surface area: The changes are surgical - only touching dependency declarations and checksums, reducing risk.

⚠️ Pre-merge Verification Recommended

While the changes look correct, I recommend verifying before tagging:

  1. Build verification: Ensure make build succeeds for both apps with the published dependencies:

    cd apps/evm && go build ./...
    cd apps/grpc && go build ./...
  2. Test suite: Run integration tests to confirm compatibility:

    make test-integration
  3. Published tags exist: Verify that execution/evm@v1.0.0-rc.1 and execution/grpc@v1.0.0-rc.1 are actually published as Git tags and available in the remote repository.

Verdict

LGTM ✅ - The changes are correct, consistent with the project's release workflow, and follow Go module best practices. The transition from local replace directives to published versions is the standard approach for release preparation.

The only blocker would be if the referenced v1.0.0-rc.1 tags for the execution modules haven't been pushed to the remote repository yet. If CI passes, that confirms they're available.


@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJan 28, 2026, 11:04 AM

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares the evm and grpc applications by updating their dependencies. Specifically, it removes local replace directives in the go.mod files and updates the versions of github.com/evstack/ev-node/execution/evm and github.com/evstack/ev-node/execution/grpc to v1.0.0-rc.1. These changes are correct and align with standard practices for preparing a release. I have reviewed the changes and found no issues of medium or higher severity.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.61%. Comparing base (463fda1) to head (a44bd55).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
+ Coverage   55.55%   55.61%   +0.06%     
==========================================
  Files         116      116              
  Lines       11477    11477              
==========================================
+ Hits         6376     6383       +7     
+ Misses       4401     4394       -7     
  Partials      700      700              
Flag Coverage Δ
combined 55.61% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt enabled auto-merge January 28, 2026 11:17
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 4cf1c92 Jan 28, 2026
47 of 48 checks passed
@julienrbrt julienrbrt deleted the julien/prep-apps branch January 28, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants