Replace test string from cornflakes to more purposeful names#252
Merged
amazingrando merged 5 commits intodevelopfrom Mar 1, 2024
Merged
Replace test string from cornflakes to more purposeful names#252amazingrando merged 5 commits intodevelopfrom
amazingrando merged 5 commits intodevelopfrom
Conversation
mikeethedude
approved these changes
Mar 1, 2024
Contributor
mikeethedude
left a comment
mikeethedude
left a comment
There was a problem hiding this comment.
Goodbye cornflake, you were fun but maybe too much like a real theme name. 🙏
This looks great Randy. Tests pass. Nothing in here that would cause issues elsewhere.
mikeethedude
added
🎉 Passes Functional Review
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the string
/home/uname/Projects/cornflake/web/themes/custom/cornflake/in tests with/home/username/Projects/drupal-project/web/themes/custom/themename/.This PR relates to a comment that came up in #173.
The reason for this change is 1) no one knows what "cornflake" is, and 2) making the directory names semantic.
How to review this pull request
npm run testand confirm that all tests pass.