[emulsify-ds/compound/issues/57] feat: replace style with global#173
Open
emircanerkul wants to merge 1 commit intoemulsify-ds:developfrom
Open
[emulsify-ds/compound/issues/57] feat: replace style with global#173emircanerkul wants to merge 1 commit intoemulsify-ds:developfrom
emircanerkul wants to merge 1 commit intoemulsify-ds:developfrom
Conversation
Contributor
|
@mikeethedude Can you take a look at this one? The renaming of the style.css to global.css is cool with me. There is another line in that file that points to someones specific home folder |
Contributor
|
Cornflake is okay because that's what the test is expecting so I'm not worried about that. This seems like it is just updating the test? We don't do much else with that so I think it is correct to only need to update the test. |
1 task
Contributor
|
@callinmullaney @mikeethedude I've created a PR for changing the test string at #252. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming
Additional Note: