test: firewall validation should FAIL without iptables fix #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
theFong
force-pushed
the
test/firewall-validation-should-fail
branch
3 times, most recently
from
0b6b71c to
c079400
Compare
- Add networking_validation.go with ValidateFirewallBlocksPort and ValidateDockerFirewallBlocksPort to verify servers on 0.0.0.0 are not accessible from outside - Extract instance validation functions to instance_validation.go - Add RunFirewallValidation to validation suite - Integrate ValidateFirewallBlocksPort into RunInstanceLifecycleValidation
theFong
force-pushed
the
test/firewall-validation-should-fail
branch
from
c079400 to
a3f8a62
Compare
Member
Author
|
Test PR successful - proved that ValidateDockerFirewallBlocksPort correctly detects when iptables DOCKER-USER rules are missing. See PR #81 for the actual validation code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests that the firewall validation correctly detects when iptables rules are missing.
Setup:
4570d27(BEFORE Drew's iptables fix in BREV-2599)Expected Result:
This validates that our test actually catches the security issue.