Fix CI build issues related to npm v7#758
Merged
arqex merged 1 commit intoarqex:masterfrom Dec 3, 2020
Merged
Conversation
Owner
|
This is great, thanks for the PR @vahissan ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Travis CI build failed for PR #757 due to breaking changes introduced with npm v7. Here's the part of the log related to this issue.
The root cause for this issue was due to
react-addons-test-utilswhich was not used anywhere. All test cases pass and the playground code runs fine after removing this package from devDependencies.Checklist