Open
Conversation
Contributor
Author
|
These are the things from the original issue which I didn't add in this PR:
|
Contributor
Author
|
CI build failed due to these reasons:
|
Owner
|
Hey @vahissan ! Thanks for this great PR, I need to find some time to review it :) If you know what's failing with the v7 of npm, can create a different PR with the fix and we merge it before this one? |
Contributor
Author
Contributor
Author
Reason 1 is resolved. But CI still fails due to reason 2. Looks like CI does not create a new build before running unit tests. |
Contributor
Author
|
Hey @arqex ! I know you must be busy. Just wanted to send a reminder in case you forgot. |
|
Hey @arqex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fixes #415 (at least partially)
I was using the library and would like to have the ability to operate the date picker without a mouse. I'm sure many others would like it too.
Checklist