RDKEMW-9893: added option to enable new dtags.

[lulicdarko]

Added option to enable new dtags.

Explanation:
This change introduces a Cmake option ENABLE_NEW_DTAGS to allow to use --enable-new-dtags for WPE Webkit build.
Primary goal is to force the linker to use DT_RUNPATH instead of legacy DT_RPATH. This change is important because:

1. DT_RUNPATH respects LD_LIBRARY_PATH unlike older DT_RPATH
2. This allows us to override system libraries or redirect library lookup at runtime without re-linkiing the entire Webkit.

Changes:

• Source/cmake/OptionsCommon.cmake

[magomez]

The approach should be defining a new option DISABLE_NEW_DTAGS, and then use it together with LD_SUPPORTS_DISABLE_NEW_DTAGS to produce the desired value, like it's done for other options in the same file.

Something like

if (LD_SUPPORTS_DISABLE_NEW_DTAGS)
set(DISABLE_NEW_DTAGS_DEFAULT ON)
else ()
set(DISABLE_NEW_DTAGS_DEFAULT OFF)
endif ()

option(DISABLE_NEW_DTAGS "Disable new dtags" ${DISABLE_NEW_DTAGS_DEFAULT})

if (DISABLE_NEW_DTAGS)
disable the dtags
else ()
enable the dtags

[magomez]

LD_SUPPORTS_DISABLE_NEW_DTAGS contains whether --disable-new-tags is supported by the linker. It shouldn't be turned into an option.

[magomez]

I'm afraid you haven't removed this option and now it's duplicated.

[lulicdarko]

I'm afraid you haven't removed this option and now it's duplicated.

Done, somehow after squash it was restored.

[lulicdarko]

The approach should be defining a new option DISABLE_NEW_DTAGS, and then use it together with LD_SUPPORTS_DISABLE_NEW_DTAGS to produce the desired value, like it's done for other options in the same file.

Something like

if (LD_SUPPORTS_DISABLE_NEW_DTAGS) set(DISABLE_NEW_DTAGS_DEFAULT ON) else () set(DISABLE_NEW_DTAGS_DEFAULT OFF) endif ()

option(DISABLE_NEW_DTAGS "Disable new dtags" ${DISABLE_NEW_DTAGS_DEFAULT})

if (DISABLE_NEW_DTAGS) disable the dtags else () enable the dtags

Hi @magomez i made changes and commited :b72b5c4.

I need to ammend also bb file and 2.38 cmake if this commit looks ok.

[magomez]

Please, join those commits into a single one, as they are part of the same change.

[lulicdarko]

Please, join those commits into a single one, as they are part of the same change.

Done