Skip to content

Conversation

@lulicdarko
Copy link

Added option to enable new dtags.

Explanation:
This change introduces a Cmake option ENABLE_NEW_DTAGS to allow to use --enable-new-dtags for WPE Webkit build.
Primary goal is to force the linker to use DT_RUNPATH instead of legacy DT_RPATH. This change is important because:

  1. DT_RUNPATH respects LD_LIBRARY_PATH unlike older DT_RPATH
  2. This allows us to override system libraries or redirect library lookup at runtime without re-linkiing the entire Webkit.

Changes:

  • Source/cmake/OptionsCommon.cmake

Copy link

@magomez magomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments than in #1603

@lulicdarko
Copy link
Author

Same comments than in #1603

It is same since it is doing exactly same as #1603 but for different webkit version. What exactly i need to change in comment.

@magomez
Copy link

magomez commented Jan 22, 2026

Same comments than in #1603

It is same since it is doing exactly same as #1603 but for different webkit version. What exactly i need to change in comment.

Yes, I know it's the same patch than #1603 but applied to 2.38. What I mean is that the review comments for this PR are the same than those I added to #1603.

@lulicdarko
Copy link
Author

Same comments than in #1603

It is same since it is doing exactly same as #1603 but for different webkit version. What exactly i need to change in comment.

Yes, I know it's the same patch than #1603 but applied to 2.38. What I mean is that the review comments for this PR are the same than those I added to #1603.

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants