-
Notifications
You must be signed in to change notification settings - Fork 12
Move examples dir under gigl
#466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/e2e_test |
|
/unit_test |
|
/integration_test |
GiGL Automation@ 24:30:54UTC : 🔄 @ 01:46:12UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 24:31:01UTC : 🔄 @ 24:38:39UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 24:31:01UTC : 🔄 @ 01:40:22UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 24:31:02UTC : 🔄 @ 01:39:07UTC : ✅ Workflow completed successfully. |
mkolodner-sc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Shubham! This change makes sense and LGTM for the reasons outlined in the PR description, but cc @kmontemayor2-sc for thoughts as well.
mkolodner-sc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hmmm I understand the appeal here to make onboarding easier, but also I feel like having I feel like That being said, having stuff be easier to onboard does make sense, how about we do something like move the toy example to somewhere inside |
|
@kmontemayor2-sc I can resonate with what you are saying.
There are tradeoffs of what makes it easier browsing on github, vs easier browsing when you pip install, vs folks just browsing the documentation website. Just extended what you suggested, maybe its better to have a |
This is hard anyways isn't it, since the installed files go in some usually obfuscated path.
Ack, but if the goal here is to make it easier for people start using gigl, there's other ways we can do it right? This path still requires them to setup a resource config, and export the compiled pipeline path, etc. Another approach here is we add some
Maybe having a "Setup wizard" is too hard but I think the robots should be able to generate one fairly easily? I guess my main concerns here are:
|
Scope of work done
As part of updating onboarding guidance, I would love to slowly build up the user instead of overwhelming them.
Thus, when someone is
pip installinggigl, I would like them as part of their onboarding validate that everything is setup correctly using some instructions similar to below vs. trying to boil the ocean with setting up their own docker, task config, preprocessor specs, etc.Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: YES