[Custom Storage 2/3] Implement custom storage main #462
Conversation
|
/e2e_test |
|
/integration_test |
GiGL Automation@ 21:28:16UTC : 🔄 @ 22:50:50UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 21:28:41UTC : 🔄 @ 22:33:15UTC : ✅ Workflow completed successfully. |
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! Left a round of comments. Generally, it could be useful to add more detail to the PR description here for the scope of the changes in this PR.
examples/link_prediction/graph_store/configs/e2e_hom_cora_sup_gs_task_config.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,246 @@ | |||
| """Built-in GiGL Graph Store Server. | |||
There was a problem hiding this comment.
if this is built in and default lets not put it under examples?
I'd pref we provide some sensible defaults so users dont need to specify this every time. Our configs are already so large.
There was a problem hiding this comment.
Btw, whats the diff between this and gigl/distributed/graph_store/storage_main.py ?
There was a problem hiding this comment.
Updated text.
Btw, whats the diff between this and gigl/distributed/graph_store/storage_main.py ?
No diffs rn, I just don't want to be relying on the example code (more) in our tests.
I do have the open TODO here for cleaning up the diffs between the files and consolidating as much as possible, just want to see how this looks in the end before breaking this all up.
There was a problem hiding this comment.
I'd pref we provide some sensible defaults so users dont need to specify this every time. Our configs are already so large.
Hmmm, I synced with @mkolodner-sc about this, and long story we can provide a "default" option here, (which will be gigl/distributed/graph_store/storage_main.py), but since graph store is kind of like "advanced mode" we'd expect that users would want to be able to customize this, so this is a lever I'm enabling.
|
/unit_test_py |
|
/integration_test |
GiGL Automation@ 21:23:33UTC : 🔄 @ 21:29:25UTC : ❌ Workflow failed. |
|
/e2e_test |
GiGL Automation@ 21:23:46UTC : 🔄 @ 22:41:39UTC : ❌ Workflow failed. |
GiGL Automation@ 21:23:47UTC : 🔄 @ 22:37:41UTC : ✅ Workflow completed successfully. |
|
/unit_test_py |
|
/e2e_test |
GiGL Automation@ 23:04:36UTC : 🔄 @ 24:16:02UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 23:04:40UTC : 🔄 @ 24:28:02UTC : ❌ Workflow failed. |
|
/e2e_test |
|
/integration_test |
|
/unit_test_py |
GiGL Automation@ 16:53:21UTC : 🔄 @ 18:19:58UTC : ❌ Workflow failed. |
GiGL Automation@ 16:53:28UTC : 🔄 @ 18:09:35UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 16:53:30UTC : 🔄 @ 18:02:28UTC : ✅ Workflow completed successfully. |
|
/e2e_test |
GiGL Automation@ 18:34:44UTC : 🔄 @ 19:55:34UTC : ✅ Workflow completed successfully. |
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! One last comment, but stamping to unblock provided it is addressed
Scope of work done
Implement logic for custom storage main
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO