-
Notifications
You must be signed in to change notification settings - Fork 113
Add configurable PUBLIC_URL for docker images #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
bd8b535
64244a5
a0fad2e
7297c15
15ffd10
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,4 +76,5 @@ EXPOSE 8080 | |
|
|
||
| ENTRYPOINT ["tini", "--", "/usr/local/bin/entrypoint.sh"] | ||
|
|
||
| CMD ["CodeCompass_webserver", "-w", "/workspace", "-p", "8080"] | ||
| CMD ["sh", "-c", "node ../../webgui-new/scripts/patch-basepath.js && CodeCompass_webserver -w /workspace -p 8080"] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, the source folder should not be in the Docker image or in the install location at all. There is an open PR #811 for that, but merging it required to fix this issue first. Instead, any script should be installed through CMake to the install location. |
||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. File should be kept executable. |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. File should be kept executable. |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. File should be kept executable. |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. File should be kept executable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without running
patch-basepath.js, how will the new GUI be accessible on the given path? The documentation says nothing about executing it, it is only done in the Dockerfile.