Skip to content

Conversation

@Nani0002
Copy link
Collaborator

No description provided.

@mcserep mcserep linked an issue Dec 18, 2025 that may be closed by this pull request
@mcserep mcserep changed the title 612 public url with docker images Add configurable PUBLIC_URL for docker images Dec 18, 2025
@mcserep mcserep self-requested a review December 18, 2025 08:06
@mcserep mcserep added this to Lab and Roadmap Dec 18, 2025
@github-project-automation github-project-automation bot moved this to In progress in Lab Dec 18, 2025
@github-project-automation github-project-automation bot moved this to In progress in Roadmap Dec 18, 2025
@mcserep mcserep added this to the Upcoming Release milestone Dec 18, 2025
@mcserep
Copy link
Collaborator

mcserep commented Dec 18, 2025

@Nani0002 For some reason, all modified files in this PR show a complete change for them, not only for the affected lines. This makes hard to find the real changes for review; and will also mess up the history.

I guess you have changed the line endings and that is the reason we see that the entire files were changed. Please fix it. You shall commit all files with Linux file endings. (That's the default behaviour for Git even on Windows, unless configured otherwise.)

https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings

@mcserep
Copy link
Collaborator

mcserep commented Dec 18, 2025

I guess you have changed the line endings and that is the reason we see that the entire files were changed. Please fix it. You shall commit all files with Linux file endings. (That's the default behaviour for Git even on Windows, unless configured otherwise.)

https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings

For this reason, generating the TypeScript client from the Thrift specification fails as well:

Generating TypeScript files from Thrift...
thrift-codegen.sh: line 2: $'\r': command not found
thrift-codegen.sh: line 4: syntax error near unexpected token `$'in\r''
thrift-codegen.sh: line 4: `  case "$1" in

CI log:
https://github.com/Ericsson/CodeCompass/actions/runs/20231847990/job/58076534945

});

app.use('/', proxyHandler);
app.use("/", proxyHandler);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should be kept executable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should be kept executable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should be kept executable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should be kept executable.

ENTRYPOINT ["tini", "--", "/usr/local/bin/entrypoint.sh"]

CMD ["CodeCompass_webserver", "-w", "/workspace", "-p", "8080"]
CMD ["sh", "-c", "node ../../webgui-new/scripts/patch-basepath.js && CodeCompass_webserver -w /workspace -p 8080"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the source folder should not be in the Docker image or in the install location at all. There is an open PR #811 for that, but merging it required to fix this issue first. Instead, any script should be installed through CMake to the install location.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File should be kept executable.

Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple occurrences of the /new were not updated at all, e.g.:

Comment on lines +167 to +168
Leaving this out of the command will start the web interface with no set path.
The new GUI will still be accessible in the /new path appended to the end of your URL.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without running patch-basepath.js, how will the new GUI be accessible on the given path? The documentation says nothing about executing it, it is only done in the Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In progress
Status: In progress

Development

Successfully merging this pull request may close these issues.

Configurable PUBLIC_URL with docker images

3 participants