generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 14
London | 25-SDC-July | Mikiyas Gebremichael | Sprint 2 | Improve with caches #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mikiyas-STP
wants to merge
3
commits into
CodeYourFuture:main
Choose a base branch
from
Mikiyas-STP:improve_with_caches
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−30
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,21 @@ | ||
| def fibonacci(n): | ||
| if n <= 1: | ||
| return n | ||
| return fibonacci(n - 1) + fibonacci(n - 2) | ||
| #def fibonacci(n): | ||
| # if n <= 1: | ||
| # return n | ||
| # return fibonacci(n - 1) + fibonacci(n - 2) | ||
| def fibonacci(n, cache=None): #cache dict is created only once to store results of previous calls. | ||
| if cache is None: | ||
| cache = {} | ||
|
|
||
| if n in cache: #if n is already cached return it | ||
| return cache[n] | ||
|
|
||
| if n <= 1: #If not cached, n <= 1, return base case (0 or 1) | ||
| cache[n] = n | ||
| else: | ||
| cache[n] = fibonacci(n - 1, cache) + fibonacci(n - 2, cache) #Cache the computed value for future reuse | ||
|
|
||
| return cache[n]. #Return the cached or newly computed value. | ||
| #Time complexity of the function was O(2**n) and now using cache it becomes, | ||
| # O(n) since each fibonacci number from 0 - n is computed once | ||
| # Space Complexity O(n) | ||
| # i.e. Cache stores up to n results since recursion depth is n | ||
49 changes: 23 additions & 26 deletions
49
Sprint-2/improve_with_caches/making_change/making_change.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,29 @@ | ||
| from typing import List | ||
|
|
||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| """ | ||
| Given access to coins with the values 1, 2, 5, 10, 20, 50, 100, 200, returns a count of all of the ways to make the passed total value. | ||
| coins = [200, 100, 50, 20, 10, 5, 2, 1] | ||
| cache = {} # To store already calculated results | ||
|
|
||
| For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin. | ||
| """ | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
| def count_ways(remaining, index): | ||
| # Base cases | ||
| if remaining == 0: | ||
| return 1 # Found a valid combination | ||
| if remaining < 0 or index == len(coins): | ||
| return 0 # Not possible | ||
| # Check cache | ||
| key = (remaining, index) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice implementation |
||
| if key in cache: | ||
| return cache[key] | ||
| # Option 1: use current coin (stay on same index) | ||
| use_it = count_ways(remaining - coins[index], index) | ||
| # Option 2: skip current coin (move to next index) | ||
| skip_it = count_ways(remaining, index + 1) | ||
| # Store result in cache | ||
| cache[key] = use_it + skip_it | ||
| return cache[key] | ||
| return count_ways(total, 0) | ||
|
|
||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| """ | ||
| Helper function for ways_to_make_change to avoid exposing the coins parameter to callers. | ||
| """ | ||
| if total == 0 or len(coins) == 0: | ||
| return 0 | ||
|
|
||
| ways = 0 | ||
| for coin_index in range(len(coins)): | ||
| coin = coins[coin_index] | ||
| count_of_coin = 1 | ||
| while coin * count_of_coin <= total: | ||
| total_from_coins = coin * count_of_coin | ||
| if total_from_coins == total: | ||
| ways += 1 | ||
| else: | ||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | ||
| ways += intermediate | ||
| count_of_coin += 1 | ||
| return ways | ||
| #Time Complexity O(total × number of coins) | ||
| # Space Complexity O(total × number of coins) | ||
| #less expensive in relation to the original function | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - good to avoid a global cache.