London | 25-SDC-July | Mikiyas Gebremichael | Sprint 2 | Improve with caches #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Mikiyas-STP wants to merge 3 commits into CodeYourFuture:main from Mikiyas-STP:improve_with_caches

+44 −30

Mikiyas-STP commented Oct 15, 2025 •

edited

Loading

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

improve my code using cache

Questions

none

Mikiyas-STP added 3 commits

October 15, 2025 18:51


          fibonacci becomes more efficient using cache

2a23699


          complexity analysis

83c01a2


          last edit

95d0f22

Mikiyas-STP added the Needs Review label

github-actions bot commented Oct 15, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Mikiyas-STP added 📅 Sprint 2 Module-Complexity labels

github-actions bot commented Oct 15, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

6 similar comments

github-actions bot commented Oct 15, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 15, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 15, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 15, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 15, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 15, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

OracPrime added the Review in progress label

OracPrime approved these changes

View reviewed changes

OracPrime left a comment

Nice work!

Sprint-2/improve_with_caches/fibonacci/fibonacci.py

    
              #    if n <= 1:

              #       return n 

              #  return fibonacci(n - 1) + fibonacci(n - 2)

              def fibonacci(n, cache=None):   #cache dict is created only once to store results of previous calls.

OracPrime Jan 26, 2026

Nice - good to avoid a global cache.

Sprint-2/improve_with_caches/making_change/making_change.py

    
                      if remaining < 0 or index == len(coins):

                          return 0  # Not possible

                      # Check cache

                      key = (remaining, index)

OracPrime Jan 26, 2026

Nice implementation

OracPrime added Complete Reviewed and removed Needs Review Review in progress labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Module-Complexity Reviewed 📅 Sprint 2