-
Notifications
You must be signed in to change notification settings - Fork 652
FEAT: Adding ConverterIdentifier and minor Identifiable refactor #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rlundeen2
merged 5 commits into
Azure:main
from
rlundeen2:users/rlundeen/2026_01_27_converter_identifier
Jan 28, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT license. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from dataclasses import dataclass, field | ||
| from typing import Any, Dict, List, Optional, Tuple, Type, cast | ||
|
|
||
| from pyrit.identifiers.identifier import Identifier | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class ConverterIdentifier(Identifier): | ||
| """ | ||
| Identifier for PromptConverter instances. | ||
|
|
||
| This frozen dataclass extends Identifier with converter-specific fields. | ||
| It provides a structured way to identify and track converters used in | ||
| prompt transformations. | ||
| """ | ||
|
|
||
| supported_input_types: Tuple[str, ...] = field(kw_only=True) | ||
| """The input data types supported by this converter (e.g., ('text',), ('image', 'text')).""" | ||
|
|
||
| supported_output_types: Tuple[str, ...] = field(kw_only=True) | ||
| """The output data types produced by this converter.""" | ||
|
|
||
| sub_identifier: Optional[List["ConverterIdentifier"]] = None | ||
| """List of sub-converter identifiers for composite converters like ConverterPipeline.""" | ||
|
|
||
| target_info: Optional[Dict[str, Any]] = None | ||
| """Information about the prompt target used by the converter (for LLM-based converters).""" | ||
|
|
||
| converter_specific_params: Optional[Dict[str, Any]] = None | ||
| """Additional converter-specific parameters.""" | ||
|
|
||
| @classmethod | ||
| def from_dict(cls: Type["ConverterIdentifier"], data: dict[str, Any]) -> "ConverterIdentifier": | ||
| """ | ||
| Create a ConverterIdentifier from a dictionary (e.g., retrieved from database). | ||
|
|
||
| Extends the base Identifier.from_dict() to recursively reconstruct | ||
| nested ConverterIdentifier objects in sub_identifier. | ||
|
|
||
| Args: | ||
| data: The dictionary representation. | ||
|
|
||
| Returns: | ||
| ConverterIdentifier: A new ConverterIdentifier instance. | ||
| """ | ||
| # Create a mutable copy | ||
| data = dict(data) | ||
|
|
||
| # Recursively reconstruct sub_identifier if present | ||
| if "sub_identifier" in data and data["sub_identifier"] is not None: | ||
| data["sub_identifier"] = [ | ||
| ConverterIdentifier.from_dict(sub) if isinstance(sub, dict) else sub for sub in data["sub_identifier"] | ||
| ] | ||
|
|
||
| # Convert supported_input_types and supported_output_types from list to tuple if needed | ||
| if "supported_input_types" in data and data["supported_input_types"] is not None: | ||
| if isinstance(data["supported_input_types"], list): | ||
| data["supported_input_types"] = tuple(data["supported_input_types"]) | ||
| else: | ||
| # Provide default for legacy dicts that don't have this field | ||
| data["supported_input_types"] = () | ||
|
|
||
| if "supported_output_types" in data and data["supported_output_types"] is not None: | ||
| if isinstance(data["supported_output_types"], list): | ||
| data["supported_output_types"] = tuple(data["supported_output_types"]) | ||
| else: | ||
| # Provide default for legacy dicts that don't have this field | ||
| data["supported_output_types"] = () | ||
|
|
||
| # Delegate to parent class for standard processing | ||
| result = Identifier.from_dict.__func__(cls, data) # type: ignore[attr-defined] | ||
| return cast(ConverterIdentifier, result) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.