Skip to content

FEAT: Adding ConverterIdentifier and minor Identifiable refactor #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rlundeen2 merged 5 commits into from
Jan 28, 2026
Merged

FEAT: Adding ConverterIdentifier and minor Identifiable refactor #1333

rlundeen2 merged 5 commits into from
Jan 28, 2026

Conversation

@rlundeen2
Copy link
Contributor

@rlundeen2 rlundeen2 commented Jan 28, 2026 •
edited
Loading

  • Implementing ConverterIdentifier which can uniquely identify converter configurations
  • Modifying Identifiable slightly, so that get_identifier is now part of the base, and _build_identifer returns and IdentifierT

Tests

  • Ran SQL Azure integration tests
  • Added ConterterIdentifier unit tests

romanlutz
romanlutz approved these changes Jan 28, 2026
View reviewed changes
jsong468
jsong468 reviewed Jan 28, 2026
View reviewed changes
@rlundeen2 rlundeen2 merged commit 90d3270 into Azure:main Jan 28, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsong468 jsong468 jsong468 left review comments

@romanlutz romanlutz romanlutz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rlundeen2 @romanlutz @jsong468