Control registering of shutdownhook#170
Open
JelmerBouma1985 wants to merge 1 commit intozonkyio:masterfrom
Open
Control registering of shutdownhook#170JelmerBouma1985 wants to merge 1 commit intozonkyio:masterfrom
JelmerBouma1985 wants to merge 1 commit intozonkyio:masterfrom
Conversation
…shutdownHook is registered. When this property is set to false no shutdown hook is registered. This makes it possible to create a spring bean of EmbeddedPostgres and let spring handle the shutdown of the EmbeddedPostgres instance in the right order and let the application shutdown gracefully
Author
|
This fixes the issue I added to embedded-database-spring-test. I now see this should be registered in this project: |
Author
|
@tomix26 can you look at this PR please? I'm now using a fork of zonky fixing this but i would like to get rid of this fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added property registerShutdownHook to EmbeddedPostgres. Default the shutdownHook is registered. When this property is set to false no shutdown hook is registered. This makes it possible to create a spring bean of EmbeddedPostgres and let spring handle the shutdown of the EmbeddedPostgres instance in the right order and let the application shutdown gracefully