Conversation
|
Deno related code updated to support wrapping and test now passing. A high level question is with the Deno support for node packages so good, is there any benefit to continuing to publish a deno build separately? |
|
Amazing @shadowspawn thank you for doing this 👏 I was dreading having to do so. |
I agree, we might want to stop doing this. Perhaps in the future after we finish this migration to ESM though? |
| ], | ||
| "engines": { | ||
| "node": ">=12" | ||
| "node": ">=20" |
There was a problem hiding this comment.
I'm bumping into some issues in yargs with Node@<20.19.0, should we consider making this our base engine version?
There was a problem hiding this comment.
Is 20.19.0 around something in particular? require(esm) ?
In which case, we might want a minimum for node 22 as well.
I am not against the idea of minimum versions within a major when there is a reason. (I need to remind myself that the early minor versions were before LTS status, so clearly not all equal! 😆 )
There was a problem hiding this comment.
I didn't notice this had been merged when I made this command. No reply necessary!
bcoe
left a comment
There was a problem hiding this comment.
One comment and potential change.
Highlights:
Wrapping issues: #89 #138
Wrapping PRs: #139 #143
See also yargs issue for ESM only: yargs/yargs#2451
Proposing require Node.js 20 since 18 is dropping out of LTS on 2025-04-30. Hopefully 20 will have require(esm) by default in v20.19.0: nodejs/node#57349
To do: