Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,31 +83,6 @@ jobs:
path: ${{ env.PRIMARY_MAVEN_MODULE }}/target/screenshots
if-no-files-found: ignore

# Ensure compatibility with Java 11
# See https://github.com/xdev-software/chartjs-java-model/issues/14
build-java-11:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v6

- name: Set up JDK
uses: actions/setup-java@v5
with:
distribution: temurin
java-version: 11

- name: Cache Maven
uses: actions/cache@v5
with:
path: ~/.m2/repository
key: ${{ runner.os }}-mvn-build-java-11-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-mvn-build-java-11-

- name: Build with Maven
run: ./mvnw -B clean package -Dmaven.test.skip=true

checkstyle:
runs-on: ubuntu-latest
if: ${{ github.event_name != 'pull_request' || !startsWith(github.head_ref, 'renovate/') }}
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 3.0.0
_Java 17 is now required_
* Updated dependencies
* Updated to Jackson v3 #477

# 2.9.1
* Updated dependencies

Expand Down
6 changes: 3 additions & 3 deletions chartjs-java-model-demo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
<parent>
<groupId>software.xdev</groupId>
<artifactId>chartjs-java-model-root</artifactId>
<version>2.9.2-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
</parent>

<artifactId>chartjs-java-model-demo</artifactId>
<version>2.9.2-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
<packaging>jar</packaging>

<organization>
Expand All @@ -20,7 +20,7 @@
</organization>

<properties>
<javaVersion>11</javaVersion>
<javaVersion>17</javaVersion>
<maven.compiler.release>${javaVersion}</maven.compiler.release>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down
8 changes: 4 additions & 4 deletions chartjs-java-model/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>software.xdev</groupId>
<artifactId>chartjs-java-model</artifactId>
<version>2.9.2-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
<packaging>jar</packaging>

<name>chartjs-java-model</name>
Expand Down Expand Up @@ -42,7 +42,7 @@
</licenses>

<properties>
<javaVersion>11</javaVersion>
<javaVersion>17</javaVersion>
<maven.compiler.release>${javaVersion}</maven.compiler.release>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand All @@ -57,9 +57,9 @@

<dependencies>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.21.0</version>
<version>3.0.3</version>
</dependency>

<!-- Tests -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,14 @@
*/
package software.xdev.chartjs.model.charts;

import java.io.UncheckedIOException;

import com.fasterxml.jackson.annotation.JsonAutoDetect;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.PropertyAccessor;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.ObjectWriter;

import software.xdev.chartjs.model.data.AbstractData;
import software.xdev.chartjs.model.options.Options;
import tools.jackson.databind.ObjectWriter;
import tools.jackson.databind.json.JsonMapper;


public abstract class AbstractChart<T, O extends Options<?, ?>, D extends AbstractData<?, ?>>
Expand All @@ -36,13 +32,16 @@ public abstract class AbstractChart<T, O extends Options<?, ?>, D extends Abstra
protected O options;

@JsonIgnore
protected ObjectWriter defaultObjectWriter = new ObjectMapper()
.setDefaultPropertyInclusion(JsonInclude.Include.NON_EMPTY)
.setVisibility(PropertyAccessor.FIELD, JsonAutoDetect.Visibility.ANY)
.setVisibility(PropertyAccessor.GETTER, JsonAutoDetect.Visibility.NONE)
.setVisibility(PropertyAccessor.IS_GETTER, JsonAutoDetect.Visibility.NONE)
.setVisibility(PropertyAccessor.SETTER, JsonAutoDetect.Visibility.NONE)
.setVisibility(PropertyAccessor.CREATOR, JsonAutoDetect.Visibility.NONE)
protected ObjectWriter defaultObjectWriter = JsonMapper.builder()
.changeDefaultPropertyInclusion(v -> v
.withValueInclusion(JsonInclude.Include.NON_EMPTY))
.changeDefaultVisibility(vc -> vc
.withFieldVisibility(JsonAutoDetect.Visibility.ANY)
.withGetterVisibility(JsonAutoDetect.Visibility.NONE)
.withIsGetterVisibility(JsonAutoDetect.Visibility.NONE)
.withSetterVisibility(JsonAutoDetect.Visibility.NONE)
.withCreatorVisibility(JsonAutoDetect.Visibility.NONE))
.build()
.writer()
.forType(this.getClass());

Expand Down Expand Up @@ -102,14 +101,7 @@ public T setDefaultObjectWriter(final ObjectWriter defaultObjectWriter)
@Override
public String toJson()
{
try
{
return this.defaultObjectWriter.writeValueAsString(this);
}
catch(final JsonProcessingException e)
{
throw new UncheckedIOException("Failed to write json", e);
}
return this.defaultObjectWriter.writeValueAsString(this);
}

@SuppressWarnings("unchecked")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@
*/
package software.xdev.chartjs.model.javascript;

import java.io.IOException;

import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.databind.JsonSerializer;
import com.fasterxml.jackson.databind.SerializerProvider;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
import tools.jackson.core.JsonGenerator;
import tools.jackson.databind.SerializationContext;
import tools.jackson.databind.annotation.JsonSerialize;
import tools.jackson.databind.ser.std.StdSerializer;


@JsonSerialize(using = JavaScriptFunction.Serializer.class)
Expand All @@ -38,13 +36,18 @@ public String getFunction()
return this.function;
}

public static class Serializer extends JsonSerializer<JavaScriptFunction>
public static class Serializer extends StdSerializer<JavaScriptFunction>
{
public Serializer()
{
super(JavaScriptFunction.class);
}

@Override
public void serialize(
final JavaScriptFunction value,
final JsonGenerator gen,
final SerializerProvider serializers) throws IOException
final SerializationContext provider)
{
gen.writeRawValue(value.function);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@
*/
package software.xdev.chartjs.model.objects;

import java.io.IOException;
import java.util.ArrayList;

import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.databind.JsonSerializer;
import com.fasterxml.jackson.databind.SerializerProvider;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
import tools.jackson.core.JsonGenerator;
import tools.jackson.databind.SerializationContext;
import tools.jackson.databind.annotation.JsonSerialize;
import tools.jackson.databind.ser.std.StdSerializer;


/**
Expand All @@ -31,35 +30,39 @@
@JsonSerialize(using = OptionalArray.Serializer.class)
public class OptionalArray<E> extends ArrayList<E>
{
public static class Serializer<T> extends JsonSerializer<OptionalArray<T>>
public static class Serializer<T> extends StdSerializer<OptionalArray<T>>
{
public Serializer()
{
super(OptionalArray.class);
}

@Override
public boolean isEmpty(final SerializerProvider provider, final OptionalArray<T> value)
public boolean isEmpty(final SerializationContext ctxt, final OptionalArray<T> value)
{
return value == null || value.isEmpty();
}

@Override
public void serialize(
final OptionalArray<T> value,
final JsonGenerator jgen,
final SerializerProvider provider)
throws IOException
final JsonGenerator gen,
final SerializationContext provider)
{
if(value != null && !value.isEmpty())
{
if(value.size() == 1)
{
jgen.writeObject(value.get(0));
gen.writePOJO(value.get(0));
}
else
{
jgen.writeStartArray();
gen.writeStartArray();
for(final T t : value)
{
jgen.writeObject(t);
gen.writePOJO(t);
}
jgen.writeEndArray();
gen.writeEndArray();
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>software.xdev</groupId>
<artifactId>chartjs-java-model-root</artifactId>
<version>2.9.2-SNAPSHOT</version>
<version>3.0.0-SNAPSHOT</version>
<packaging>pom</packaging>

<organization>
Expand Down