Update parameter types according to API docs#73
Merged
ex10ded merged 2 commits intox10xchange:starknetfrom Feb 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates parameter types in several API client methods to align with the official Extended Exchange API documentation. The changes make optional parameters that were incorrectly marked as required, and mark one previously optional parameter as required according to the API specification.
Changes:
- Updated
get_candles_historyto make thelimitparameter required (removed Optional) - Updated
get_trades,get_fees, andget_leverageto make themarket_namesparameter optional - Added a helpful comment in an example file suggesting testnet configuration option
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| x10/perpetual/trading_client/markets_information_module.py | Made limit parameter required in get_candles_history method |
| x10/perpetual/trading_client/account_module.py | Made market_names parameter optional in get_trades, get_fees, and get_leverage methods |
| examples/01_create_limit_order.py | Added clarifying comment about testnet configuration option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ex10ded
previously approved these changes
Jan 26, 2026
Contributor
|
@lethaale thanks of this, it looks good - just one small issue, it's failing the linter check. Could you run |
Contributor
Author
|
Just pushed! |
ex10ded
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://api.docs.extended.exchange/#get-trades
params market is not required => set as Optional
https://api.docs.extended.exchange/#get-fees
params market is not required => set as Optional
https://api.docs.extended.exchange/#get-current-leverage
params market is not required => set as Optional
https://api.docs.extended.exchange/#get-candles-history
params limit is required => removed Optional