Enable support for months and years#26
Open
amotl wants to merge 1 commit intowroberts:masterfrom
panodata:months-and-years
Open
Enable support for months and years#26amotl wants to merge 1 commit intowroberts:masterfrom panodata:months-and-years
amotl wants to merge 1 commit intowroberts:masterfrom
panodata:months-and-years
Conversation
Author
|
Hi again, we also submitted this patch to onegreyonewhite#1, where @onegreyonewhite seems to have taken over maintenance of this fine package. With kind regards, |
ArnauMunsOrenga
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Will,
first things first: Thanks a stack for conceiving this excellent package.
Attaching to #7 and #13, while recognizing your arguments, I still believe it would be reasonable to assume "30 days for a month" and "365 days for a year" as the basis for calculations with those units. I agree that this approximation should be documented well.
Based on what has been done with #10 by @duramato, this patch activates the corresponding lines.
With kind regards,
Andreas.