Open
Conversation
Dragon1320
requested changes
Aug 9, 2020
Member
Dragon1320
left a comment
Dragon1320
left a comment
There was a problem hiding this comment.
Whats here looks fine, but ik theres a lot of input validation in the search route that i do that probably throws 500s, just make that throw 400s instead if its a user input issue, but obviously keep it as 500 if its a genuine issue.
Dragon1320
requested changes
Aug 24, 2020
Member
Dragon1320
left a comment
Dragon1320
left a comment
There was a problem hiding this comment.
the input validation i referred to in the last review is specific to the search route, basically im throwing a lot of errors in the db service, this causes them all to be 500s as the controller doesnt know any better, so either move the validation that im doing in the service to the controller or find a way to distinguish between errors thrown in the service that should be 400s and 500s
nnfhhvbb
approved these changes
Oct 12, 2024
nnfhhvbb
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #79