Additional changes for 5.0 (Ruby 4 support) branch#566
Merged
etagwerker merged 5 commits intowhitesmith:fixes/555from Jan 27, 2026
Merged
Additional changes for 5.0 (Ruby 4 support) branch#566etagwerker merged 5 commits intowhitesmith:fixes/555from
etagwerker merged 5 commits intowhitesmith:fixes/555from
Conversation
# Conflicts: # CHANGELOG.md
- restored notes and one change that got dropped in rebasing - split out the changelog to include 4.12 release we haven't done yet
etagwerker
approved these changes
Jan 27, 2026
Collaborator
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@faisal Looks good, thank you! 💯
etagwerker
added a commit
that referenced
this pull request
Jan 27, 2026
* Changes needed for Ruby 4.0.0 * Test with Ruby 4.0 too * Patch FakeFS * Add a note about Ruby 4.0 * Apply patch by @faisal * Remove irb and bump dependency on fakefs * undef :path * Additional changes for 5.0 (Ruby 4 support) branch (#566) * Update version, and version compatibility, for 5.0 release. * run mdl with Ruby 4 # Conflicts: # CHANGELOG.md * Fixed up changelog - restored notes and one change that got dropped in rebasing - split out the changelog to include 4.12 release we haven't done yet * Require ostruct, because Ruby 4.0 no longer bundles it. * [CHANGE] Update byebug dependency, for Ruby 4.0 compatibility fixes * Small fix to avoid unnecessary strictness in comparison --------- Co-authored-by: Faisal N Jawdat <faisal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a number of changes on top of when we last touched the 5.0 branch:
It updates the version, and it updates the version compatibility matrix in README.md (to match what we already have in the 4.12.0 release)
It runs mdl in CI using Ruby 4 (which we'd had in the past but dropped in branch shuffles)
It moves ostruct from the development dependencies to the runtime dependencies because Ruby 4 drops ostruct.
It updates the byebug dependency to a version with fixes with Ruby 4 support.
Minor changelog weaks beyond just adding the above
Add an entry to the changelog
Squash all commits into a single one
Describe your PR, link issues, etc.
This is kind of a mess and we'll need to clean up the final PR, but we had that problem anyway.