Technical updates #447
Open
Technical updates #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Update dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
wai-website-datasubmodule that was previously used to get:theme-plugin.rbfile used to add ids to H2s in order to build the table of contents,This data is now inherited from the
wai-website-themeorwai-website-plugingems.Note: This repository will continue to use https://github.com/w3c/aria-practices as a submodule.
This PR also updates the Ruby version used from 3.3.3 to 3.4.8, and the Bundler version from 2.5.14 to 4.0.3.
The Netlify configuration now:
wai-website-themeandwai-website-plugingems before building the site.Finally, the GitHub Actions workflows now use Ruby 3.4.8.
How to build the site locally from now on
Refer to the the updated README.
How to update Ruby locally:
Install Ruby 3.4.8. Jekyll recommends using
ruby-install:Configure your version manager to use Ruby 3.4.8. Jekyll recommends using
chruby:Update your
~/.zshrcfile to use Ruby 3.4.8 by default (optional)For more context on the changes made to the theme and the wai-website-plugin, see w3c/wai-website-theme#171, w3c/wai-website-theme#173 and w3c/wai-website-plugin#4
Tasks
To do, after merging https://github.com/w3c/wai-website-plugin/pull/4 and https://github.com/w3c/wai-website-theme/pull/173: - [x] Update the `Gemfile` to use the `main` branch for the `wai-website-plugin` and the `wai-website-theme` - [x] Run `bundle install` and commit `Gemfile.lock`