[WIP] Schema validator

[michalksiazek]

Proposed change to not use ActiveModel::Validations.

TODO:

• Test output of those validation errors
• Meta and errors should be optional (currently validator returns that as schema errors)

[choosen]

Looks fine 👍

Can you remove active_model from dev_deps ?
And upgrade schema to v7 + schemer upgrade (as discussion in target PR)
http://json-schema.org/specification-links.html#draft-7

[choosen]

Suggested change

	errors = []
	schema.validate(payload).each do |validation_error|
	errors << nice_error(validation_error)
	end
	errors = schema.validate(payload).map do |validation_error|
	nice_error(validation_error)
	end

[Marahin]

I already removed my previous comment; I didn't realize it was actually a request to merge into target PR.

[Marahin]

About meta and other optional keywords, if I remember correctly I've done that as manual change in the schema (basically making it less strict):

https://github.com/visualitypl/jsonapi_parameters/pull/45/files#diff-0b898c8dfb1316b8cc5b9fa193dd5bcea2d856082ea8777060f2b44e5b72225eR78

Try that, maybe that will resolve the issue.

[choosen]

schemer seems not caching validation result so:

Suggested change

	unless schema.valid?(payload) # rubocop:disable Style/GuardClause
	errors = []
	schema.validate(payload).each do |validation_error|
	errors << nice_error(validation_error)
	end
	validation_errors = schema.validate(payload)
	unless validation_errors.blank? # rubocop:disable Style/GuardClause
	errors = validation_errors.map do |validation_error|
	nice_error(validation_error)
	end