Skip to content

fixing infinite loop with large cache attempts on initial cache Sets#26

Open
kris-watts-gravwell wants to merge 1 commit intovictorspringer:masterfrom
kris-watts-gravwell:issue25CacheLockup
Open

fixing infinite loop with large cache attempts on initial cache Sets#26
kris-watts-gravwell wants to merge 1 commit intovictorspringer:masterfrom
kris-watts-gravwell:issue25CacheLockup

Conversation

@kris-watts-gravwell
Copy link
Contributor

This PR addresses issue #25

What it does:

  1. make the evict function return a boolean so that we can break out of the loop if nothign is evicted
  2. Make the Set function check if the response can be cached at all and abort if it can't
  3. Add a test for both scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant