Remove hardcoded Redis Ring to allow users to use any Redis mode they want#10
Open
binhnguyenduc wants to merge 2 commits intovictorspringer:masterfrom
Open
Remove hardcoded Redis Ring to allow users to use any Redis mode they want#10binhnguyenduc wants to merge 2 commits intovictorspringer:masterfrom
binhnguyenduc wants to merge 2 commits intovictorspringer:masterfrom
Conversation
…diser interface. This is to allow more flexibility in different redis setup, by removing the hardcoded redis Ring, the library gives back control to its user in choosing which kind of redis client fits them best: Client, FailoverClient, Ring, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the hardcode use of Redis Ring in
adapter/redispackage. This is limiting as it requires users to use Redis Ring if they want to use Redis as cache backend.I have modified to include a new interface,
Rediser. This will allow users to use any type of redis client they want from package redis v7.If you think this will be of benefits to community, please consider merging this Pull Requests. Thank you.