Open
Conversation
Author
|
I also added my site to the utterances list |
Author
|
hello???? |
zsdycs
reviewed
Jun 9, 2021
Contributor
zsdycs
left a comment
zsdycs
left a comment
There was a problem hiding this comment.
Hi~ @VatsaDev
After reading this "PR", I have the following thoughts:
- The "configuration-component.ts" file has not been modified. You should add options for this theme in
<select id="theme" ……>……</select>. - What is
colors.txtused for? - The "button.scss" code is not properly indented and should be formatted.
- The title of this "PR" is "Dark purple theme for utterances", and the
SITES.mdfile should not be modified.
good luck！
Contributor
|
In addition, I did not run this code, if the renderings are attached, it will make this "PR" icing on the cake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi its my first time on an open source project and I made a dark purple theme for utterances, hope you add it!
-vatsadev