Open
Conversation
Owner
|
Thanks for PR. I looked at your commits.
|
Author
|
Hello
Link to the task that I did:
https://gist.github.com/urpylka/74068971f2921f18d27ba5c2b459f446
Maybe this is not the latest version of the assignment?
пт, 13 сент. 2019 г., 10:33 Artem Smirnov <notifications@github.com>:
… Thanks for PR. I looked at your commits.
1. And I ask you to squash your commits into one w the understandable
message.
2. Also if you participate in the test see at task 2. There I asked to
make changes in config.json after changes in QT form and back. You
made just second part. You need to use save button. You can see how that
work in DeviceWindow.
[image: Screenshot 2019-09-13 at 10 26 03]
<https://user-images.githubusercontent.com/5459558/64841920-9ab74180-d611-11e9-9dec-cb846ac5ecea.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2?email_source=notifications&email_token=ANEMOS2NXSPRKWI2CCJ3W2LQJMX5NA5CNFSM4IWHF6K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6UDF4Q#issuecomment-531116786>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANEMOS5XT6UE3HQDZAH2D43QJMX5NANCNFSM4IWHF6KQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

To associate the change of the "Include" and "Exclude" fields with the corresponding fields in the config.json file, I added to the class constructor: