Unmount React Components when removing elements from Dom#322
Open
adamzapasnik wants to merge 1 commit intouber:masterfrom
Open
Unmount React Components when removing elements from Dom#322adamzapasnik wants to merge 1 commit intouber:masterfrom
adamzapasnik wants to merge 1 commit intouber:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #321
If the code doesn't meet your quality standards, then feel free to rewrite it on your own. I don't have much experience in working with js/react libs, so I'm afraid I won't be able to meet your requirements.
I tried to test it with my app via
yarn link, but I couldn't make it work, heh... Also wanted to check it via/examples, but they are outdated, aren't they?Let me know if there is anything I can do to fix it "asap".
EDIT:
Now that I think about it, it's not a complete solution. React components (including zoom) should be also removed in
componentWillUnmountI think?