This repository was archived by the owner on Nov 13, 2021. It is now read-only.
Store timestamp as POSIXct, not POSIXlt#92
Open
caijun wants to merge 5 commits intotwitter:masterfrom
Open
Conversation
|
|
amurthy-perf
approved these changes
Sep 17, 2018
amurthy-perf
left a comment
There was a problem hiding this comment.
Dataset here (https://www.kaggle.com/boltzmannbrain/nab) needs this code change.
Looksgood.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the Error: Column
timestampis a date/time and must be stored as POSIXct, not POSIXlt, we should store thetimstampvariable as POSIXct, not POSIXlt, which also make it compatible with dplyr, ggplot2 etc. packages that requires putting POSIXct in a data frame. see issue tidyverse/dplyr#179This PR may also fix the issue #2