Type aliases, list splats, generic types and f-strings#320
Open
vanessa-rodrigues wants to merge 2 commits intotree-sitter:masterfrom
Open
Type aliases, list splats, generic types and f-strings#320vanessa-rodrigues wants to merge 2 commits intotree-sitter:masterfrom
vanessa-rodrigues wants to merge 2 commits intotree-sitter:masterfrom
Conversation
2 tasks
Contributor
Author
|
By the way, the tests are failing on the Node binding. I haven’t made any changes to them (and don’t actively use them), so I’m not sure what’s causing the failures. The grammar updates fix several bugs, and I wanted to contribute those improvements back—happy to help investigate if you have guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix conflict between type_alias_statement and primary_expression.
Fix several parsing errors related to list splats, f-strings and generic types. All tests were added to corpus.
Add some fields throughout the grammar and fix a typo (?) on the type_parameters rule, renaming it from type_parameter.