icon image files found missing with new model gen4 and gen 5 echo units now being detect#1204
Open
jshimota01 wants to merge 3 commits intotonesto7:masterfrom
Open
icon image files found missing with new model gen4 and gen 5 echo units now being detect#1204jshimota01 wants to merge 3 commits intotonesto7:masterfrom
jshimota01 wants to merge 3 commits intotonesto7:masterfrom
Conversation
FIles found to be missing for new model units now exposed.
Replacement of existing DND_Off to reflect speaker is on, not off.
This set of changes is only to clean: A typo on Gen 2 echo spot. Removal of Echo Dot found as Echo Show Add of Echo Dot missing for Gen 5 Echo Dot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've uploaded 7 files - 5 found in the icon folder, and a replaced file in devices subfolder to icons that repairs an incorrect icon.
Checklist:
I'm not great with PR's so I reforked, uploaded only my files recommendations and built this PR to allow you an easy method to induct the changes.
Types of changes
Bug fix - device page on HE devices of Gen 4 and Gen 5 Echo Dots and Gen 4 and Gen 5 Echo Dots With Clock now have associated images.
Bug fix - device missing image for 'na.png' during playback stopped or nothing selected on HE device page.
Bug fix - code had DND on and off icons that were identical. DND on should show the speaker with a line crossing it, where DND off should show the speaker exposed. Master repo has identical icons so didn't reflect proper state correctly
How Has This Been Tested?
I forked ES about 14 months ago, so as to correct some issues I had with it. I then modded it and switched off the ES found through HE HPM and was using my customized version. This allowed me to fix a bunch of things like broken icons, the playback code on devices in multidevices and just some things I felt I would benefit on. I never shared with the community as ES is a very special app and way way way above my paygrade.
I've been running on my custom version since 8-2024. About 30 days ago I saw activity on the forums around ES and felt I wanted to use the original again so I would benefit. However, that exposed all the things I had fixed... So here we are.!
I also have an a number of items in the device detection section that are more accurate in one case, a repair of a break in another and 4 more devices detected then the 8-2024 version. I plan after sending the PR, to push my changes and submit a 2nd PR in case you care to ingest them. thanks!
Shu